leinardi / leinardi/FloatingActionButtonSpeedDial

Snackbar behaviour breaks clicks, scrolling and similar for one touch

Open
#153 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.5k
Forks
149
PR merge metrics
No merged PRs in 30d

Description

Step 2: Describe your environment
  • Library version: 3.1.1
  • Android version: 9
Step 3: Describe the problem:
Steps to reproduce:

What I do is following:

  • I add a simply view like following:
<com.leinardi.android.speeddial.SpeedDialView
        android:id="@+id/fab"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="bottom|end"
        android:layout_margin="@dimen/fab_margin"
        app:backgroundTint="?colorAccent"
        app:layout_behavior="@string/speeddial_scrolling_view_snackbar_behavior"
        app:sdMainFabClosedIconColor="@android:color/white"
        app:sdMainFabClosedSrc="@drawable/ic_add_black_24dp" />
  • I add a few items to my RecyclerView
  • the items are not scrollable yet because they all fit on the screen
  • now I try to scroll down
  • afterwards I see what I describe under Observed Results
  • I remove the layout behaviour and everything works fine again
Observed Results:

As soon as I add the app:layout_behavior="@string/speeddial_scrolling_view_snackbar_behavior" behaviour to the SpeedDialView I see that I can break the touch handling of the RecyclerViewfor at least one click / touch. This means the RecyclerView is not responding to a scroll or click once and will only respond when I try it the second time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with SpeedDialView and the speeddial_scrolling_view_snackbar_behavior layout behavior shown in the report. Reproduce on Android 9 with a RecyclerView whose items initially fit on screen, then compare touch handling with the behavior removed. Done means the first scroll or click after the attempted scroll responds normally while the behavior remains enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.