Orientation change issue

Nobody has claimed this yet.

Orientation issue

Hi

I started using this speed dial and I'm running into an issue with orientation

In protrait mode I load items and set lables. in landscape mode I do noty set the labels

when the activity detects an orientation change I clear the itmes and reload them with labels on or off based on the orientation.
I also set the oriienation of the speed dial itsel and reopen it if it was open before the orientation change

Starting in protrait mode: all is good. FABs are displayed vertivcally with labels.
Change to landscape mode: all is good. FABS displayed horizontally without labels
Back to protrait: Problem: FABS are displayed vertically but the labels are missing.

Is there somethins I'm missing?

Thanks for the help

Here is the orientation change code:


    @Override
    public void onConfigurationChanged(Configuration newConfig) {
        super.onConfigurationChanged(newConfig);
        boolean open = mSpeedDialView.isOpen();
    if (newConfig.orientation == Configuration.ORIENTATION_PORTRAIT) {
        setFabItems(newConfig.orientation);
        mSpeedDialView.setOrientation(LinearLayout.VERTICAL);
    } else {
        setFabItems(newConfig.orientation);
        mSpeedDialView.setOrientation(LinearLayout.HORIZONTAL);
    }
    
    mSpeedDialView.requestLayout();
    if (open) {
        mSpeedDialView.open();
    }
}


    private void setFabItems(int orientation) {
        SpeedDialActionItem item1 = null;
        SpeedDialActionItem item2 = null;
    mSpeedDialView.clearActionItems();
    
    if (orientation == Configuration.ORIENTATION_PORTRAIT) {
        item1 = new SpeedDialActionItem.Builder(R.id.fab_item1, R.drawable.ic_fab_item1)
                .setLabel(R.string.fab_item1)
                .setFabBackgroundColor(getResources().getColor(R.color.colorPrimary, null))
                .setLabelBackgroundColor(getResources().getColor(R.color.colorPrimaryDark, null))
                .setLabelColor(getResources().getColor(R.color.grey_18, null))
                .create();

        item2 = new SpeedDialActionItem.Builder(R.id.fab_item2, R.drawable.ic_fab_item2)
                .setLabel(R.string.fab_item2)
                .setFabBackgroundColor(getResources().getColor(R.color.colorPrimary, null))
                .setLabelBackgroundColor(getResources().getColor(R.color.colorPrimaryDark, null))
                .setLabelColor(getResources().getColor(R.color.grey_18, null))
                .create();
    } else {
        item1 = new SpeedDialActionItem.Builder(R.id.fab_item1, R.drawable.ic_fab_item1)
                .setLabel(R.string.fab_item1)
                .setFabBackgroundColor(getResources().getColor(R.color.colorPrimary, null))
                .create();

        item2 = new SpeedDialActionItem.Builder(R.id.fab_item2, R.drawable.ic_fab_item2)
                .setLabel(R.string.fab_item2)
                .setFabBackgroundColor(getResources().getColor(R.color.colorPrimary, null))
                .create();
    }

    mSpeedDialView.addActionItem(item1);
    mSpeedDialView.addActionItem(item2);
}

Start by tracing the orientation-change flow in onConfigurationChanged and setFabItems, focusing on how mSpeedDialView handles action items and labels after clearActionItems(). Reproduce the portrait-to-landscape-to-portrait sequence and verify that the portrait labels are restored when the speed dial is reopened.

Written by the indexing model from the issue text.

Description

Contributor guide

First steps

Research direction

Assessment