leeoniya / leeoniya/uPlot

make it possible to indicate multiple x and y facets in mode 2

Open
#883 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
10.5k
Forks
463
PR merge metrics
No merged PRs in 30d

Description

for scale ranging, 2d objects like heatmap cells can have xMin xMax yMin yMax facets that should be used for finding scale range. currently only a single x and y facet is used, leading to clipping of data.

https://github.com/leeoniya/uPlot/blob/38f63de6843d64e703fa23596d9525c15d003ecd/src/uPlot.js#L1323-L1330

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/uPlot.js at lines 1323-1330 and trace the mode 2 scale-ranging logic. Check how xMin, xMax, yMin, and yMax facets are currently selected for 2D objects, then verify that all relevant facets contribute to the scale range without clipping heatmap cells.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.