leeoniya / leeoniya/uPlot

Preserve selection

Open
#882 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
10.5k
Forks
463
PR merge metrics
No merged PRs in 30d

Description

Firstly thanks for this amazing library.

I've been trying to preserve selection when I've got cursor.drag.setScale = false in a sync'd ranger.
I had a look at the https://leeoniya.github.io/uPlot/demos/zoom-ranger.html demo,
and once a selection is made, if you click anywhere else, the selection is reset in the ranger.

Is there an easy way to prevent that reset? I've tried setting cursor.bind.click to () => null, but that didn't work.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reset in the zoom-ranger demo linked in the issue with cursor.drag.setScale disabled in a synced ranger. Start by tracing the ranger's selection behavior when clicking elsewhere and the effect of cursor.bind.click. Done means the selection remains preserved after another click.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.