series without a stroke cause bugs in point rendering and hover points
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 463
- PR merge metrics
- No merged PRs in 30d
Description
pretty surprising that this has never come up.
the logic for setting default point fills and stokes is actually quite complicated, given that it has to account for various combos of missing settings, and that point fills come from series strokes unless explicitly defined otherwise.
you can still get it working by being explicit. it's just the defaults/fallbacks that are not working.
series: [
{},
{
// stroke: "red",
fill: "rgba(255,0,0,0.1)",
value: fmtVal,
points: {
stroke: "red",
}
},
{
// stroke: "green",
fill: "rgba(0,255,0,0.1)",
value: fmtVal,
points: {
stroke: "green",
}
},
{
// stroke: "blue",
fill: "rgba(0,0,255,0.1)",
value: fmtVal,
points: {
stroke: "blue",
}
},
],
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the provided series configuration, then trace the JavaScript logic that supplies default and fallback values for series stroke, fill, and point stroke. Check both point rendering and hover points when series strokes are omitted, and verify the behavior against the explicit-stroke example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100