leeoniya / leeoniya/uPlot

default cursor sync scales keys are set with mode: 1 assumptions

Open
#715 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
10.5k
Forks
463
PR merge metrics
No merged PRs in 30d

Description

https://github.com/leeoniya/uPlot/blob/ddaf5d85a3c796e11868357dd1dac46e9548de61/dist/uPlot.esm.js#L5256

need to check against mode: 2 and use scale keys from facets, or just use scale from first hz and first vt axes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at dist/uPlot.esm.js around line 5256 and inspect how default cursor synchronization selects scale keys for mode: 1. Compare that behavior with mode: 2, including the scales available from facets and the first horizontal and vertical axes; done means synchronization uses the correct scale keys in both modes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.