leeoniya / leeoniya/uPlot

Chrome crash on scale range [1, 1]

Open
#620 8 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
10.5k
Forks
463
PR merge metrics
No merged PRs in 30d

Description

uPlot version: 1.6.17
Browser: Chrome 95.0.4638.69
OS: macOS

Bug description:
If you set scale range to equal numbers like [1,1], [2,2] and etc.. except [0,0] memory usage skyrockets and tab crashes.
Screenshot 2021-11-16 at 14 08 49

Expected behaviour:
In previous versions of uPlot if scale has equal range values it wouldn't crash the tab and scale label would be hidden

To reproduce:
In any of the project examples set scale range to [1,1]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in any project example with a scale range of [1,1] or [2,2] in Chrome, then trace the scale-range handling used by the examples. The fix is done when equal nonzero ranges no longer cause runaway memory use or a tab crash, and the scale label behavior matches the expected result.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.