[ts] conflicting font types
Open
Nobody has claimed this yet.
help wanted
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 463
- PR merge metrics
- No merged PRs in 30d
Description
uPlot.Axis currently defines:
font?: CanvasRenderingContext2D['font'];
labelFont?: CanvasRenderingContext2D['font'];
While true for values passed into constructor, various callbacks actually need to deal with values processed by pxRatioFont(), which, it seems, actually has (non-null? not sure about that) return type [string, number, number].
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the uPlot.Axis font and labelFont definitions alongside the pxRatioFont() entry point and the callbacks that consume their values. Confirm the returned tuple's nullability and make the public and processed font types consistent, with coverage for both constructor values and callback values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100