leeoniya / leeoniya/uPlot

Touch zoom plugin: touch outside issue

Open
#478 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

demos enhancement
Dominant language
JavaScript
Stars
10.5k
Forks
463
PR merge metrics
No merged PRs in 30d

Description

Hi,
In the touch zoom example, if you touch outside of <div class="u-over"></div> and try to pinch two fingers, the zoom will immediately go to maximum.
I shot a video:

HVs5Si8s2b

P.S.
And the second question, how can we prevent excessive zoom, in which the display does not show dots and lines?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the touch zoom example at https://leeoniya.github.io/uPlot/demos/zoom-touch.html and reproduce a two-finger pinch beginning outside the

element. Trace the touch zoom plugin's handling of that gesture and define done as preventing the immediate jump to maximum zoom, while also clarifying how excessive zoom should be constrained.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.