leeoniya / leeoniya/uPlot

use SVG for markers

Open
#431 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
10.5k
Forks
463
PR merge metrics
No merged PRs in 30d

Description

ideally, tiny, single-path SVGs where the path d attribute can be reused for both the svg elements of hover points as well as Path2D cached paths for canvas draw.

https://github.com/grafana/grafana/pull/30192

these can be in the core if they're small and visually distinctive:

  • circle
  • square
  • triangle
  • star
  • plus
  • asterisk
  • rhombus
  • cross (rotated plus?)

image

image

e.g. tiny star:

<svg viewBox="0 0 260 245"><path d="M55 237L129 9l74 228L9 96h240"/></svg>

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the marker-rendering code for hover-point SVG elements and the cached Path2D paths used by canvas drawing. Compare the requested marker shapes and shared SVG path data with the linked pull request. Done means the listed visually distinctive markers use reusable, single-path SVG data in both rendering paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.