leeoniya / leeoniya/uPlot

Float32Arrays with `NaN`s as its first elements not plotting anymore on version > 1.6.30

Open
#1,045 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
JavaScript
Stars
10.5k
Forks
463
PR merge metrics
No merged PRs in 30d

Description

Hi 👋

It seems like Float32Arrays with some NaN values at the start are no longer plotted after version 1.6.30. Just one value at the very start of the array is enough to break the plotted chart. It then shows up like this:

Image

I've also created a fiddle here: https://jsfiddle.net/adilrabbani/0s6L7mhc/3/ (the second series has a NaN at first index)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked JSFiddle and compare its behavior across versions before and after 1.6.30. Trace how the chart handles leading NaN values in the second series. Done means Float32Arrays with one or more initial NaNs render their remaining values correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.