move all key cmp from Filter to Trove->FiltMatchAll()
Open
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
since filtering on keys is only valid within a collection, it doesn't belong in the filter. as a transition can make/pass a tmp object with _key as a property.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Filter implementation and Trove->FiltMatchAll(), then trace how key comparisons and transition temporary objects with a _key property are handled. The change is complete when key comparisons no longer belong in Filter and collection filtering still handles them through Trove->FiltMatchAll().
Written by the indexing model from the issue text.
Assessment
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100