leedo / leedo/noembed

XKCD mouseover text is not HTML encoded

Open
#75 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Perl
Stars
496
Forks
91
PR merge metrics
No merged PRs in 30d

Description

Shows up here: https://noembed.com/embed?url=http%3A%2F%2Fxkcd.com%2F859%2F

The HTML produced (after parsing the JSON) is:

<img /="/" alt="(" src="https://noembed.com/i///imgs.xkcd.com/comics/(.png" title="Brains aside, I wonder how many poorly-written xkcd.com-parsing scripts will break on this title (or ;;"''{<<[' this mouseover text."">

Which results in the title attribute getting cut off by the raw quotes:

Brains aside, I wonder how many poorly-written xkcd.com-parsing scripts will break on this title (or ;;

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the noembed URL for xkcd.com/859 and inspect the XKCD provider and HTML-generation entry point that produces the shown markup. Trace how the mouseover text reaches the title attribute. Done means the title preserves the complete text when parsed as HTML, including quotes and angle brackets, without breaking the attribute.

Written by the indexing model from the issue text.

Assessment

Tech stack
perl
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.