leecade / leecade/react-native-swiper
loadMinimalSize and loadMinimalLoader types should be declared as number and React.Node in index.d.ts
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
Which OS ?
N/A
Version
Which versions are you using:
- react-native-swiper v1.5.14
- react-native v0.58.6
Expected behaviour
When using react-native-swiper in a TypeScript project, I should be able to enable the loadMinimal prop and specify the loadMinimalSize as a number. I should also be able to specify loadMinimalLoader as anything renderable by React.
Actual behaviour
TypeScript compilation fails because loadMinimalSizeand loadMinimalLoader are both declared as boolean types in index.d.ts.
How to reproduce it
N/A
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open index.d.ts and inspect the declarations for loadMinimalSize and loadMinimalLoader. Update their types to match the expected number and React.Node values, then verify that a TypeScript project using these props compiles successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, react-native, typescript
- Domain
- developer-experience, mobile
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100