leecade / leecade/react-native-swiper
can have both dots and renderpagination
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
Which OS ?
mac OS high sierra
Version
Which versions are you using:
- react-native-swiper v1.5.14?
- Expo sdk
Expected behaviour
have both dots and render pagination
Actual behaviour
when i add renderPagination prop the dots remove
How to reproduce it>
add renderpagination:
dot={<View style={{ backgroundColor: 'rgba(255,255,255,.3)', width: 7, height: 7, borderRadius: 7, marginHorizontal: 3 }} />}
activeDot={<View style={{ backgroundColor: '#fff', width: 8, height: 8, borderRadius: 7, marginHorizontal: 3 }} />}
loop={false}
renderPagination={renderPagination}
const renderPagination = (index, total, context) => {
return (
{index + 1}/{total}
)
}
Steps to reproduce
1.add dot props
2.add renderpagination props
3.dots remove
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the renderPagination entry point and inspect how it interacts with the dot and activeDot props. Reproduce the provided example with loop={false}; done means the custom pagination renders while the dots remain visible, or the issue is clarified if both options are intentionally exclusive.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100