leecade / leecade/react-native-swiper

[Discuss] Make use of RN 0.57's new ScrollView snapToOffsets & fixes to snapToInterval?

Open
#858 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
10.5k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

Which OS ?

Both

Version

Which versions are you using:

  • react-native-swiper v1.5.13 (my fork)
  • react-native v0.57
Discussion:

Regarding PR: https://github.com/facebook/react-native/commit/ef7e99c which is landing in RN 0.57 release soon. Can we make use of the new snapToOffsets for react-native-swiper?

Quoting from PR:

Summary:

  • Added snapToOffsets prop to ScrollView. Allows snapping at arbitrary points.

  • Fixed pagingEnabled not being overridden by snapToInterval on iOS.

  • Fixed Android requiring pagingEnabled to be defined alongside snapToInterval.

  • Added support for decelerationRate on Android.

  • Fixed snapping implementation. It was not calculating end position correctly at all (velocity is not a linear offset).

    • Resolves #20155
  • Added support for new content being added during scroll (mirrors existing functionality in vertical ScrollView).

  • Added support for snapToInterval.

    • Resolves #19552

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing react-native-swiper's current ScrollView snapping behavior and the linked React Native 0.57 change for snapToOffsets and snapToInterval. Determine the intended behavior on both iOS and Android; done should mean the swiper uses the new APIs correctly without regressing existing snapping behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.