leecade / leecade/react-native-swiper
don't read prop title of children
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
I know it's a feature that every children can have a title, but i think that's a really bad idea.
I only found this feature by accident, because my children had a property called title which was an object (Because it could be translated) and I got a very cryptic error.
It's an anti-pattern to assume any property on children.
Instead, allow to pass an array of titles which will be selected by index.
or: allow to disable or change this functionality, e.g. by giving a function extractTitle which will receive the current child or so.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating the code that reads a child's title and review how title values are used; the issue does not establish whether indexed titles, configurable extraction, or disabling the behavior is the desired definition of done.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100