leecade / leecade/react-native-swiper
Master is broken on Android
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
Which OS ?
Android
Version
- react-native-swiper v1.5.13
- react-native v0.55.3
Expected behaviour
Should work without making assumptions about children props
Actual behaviour
It's broken on Android when you have a children that uses a string as title prop.
How to reproduce it>
<Swiper>
<View title="Teste" />
</Swiper>
This is caused because of the following piece of code:
https://github.com/leecade/react-native-swiper/blob/1.5.13/src/index.js#L561-L569
This expects that the user always use Text element on their title props, I think this should be either better documented here: https://github.com/leecade/react-native-swiper#props-of-children or fixed
But I don't know if this lib is still receiving contributions, since the last merge PR was on Feb.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/index.js at lines 561-569 and compare its handling of a string title prop with the README section "Props of children". Reproduce the Android case using the provided Swiper and View example; done means either the child works without requiring a Text title or the expectation is clearly documented there.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100