leecade / leecade/react-native-swiper
Resize to container and not just window
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 10.5k
- Forks
- 2.3k
- PR merge metrics
- No merged PRs in 30d
Description
Great component! I had a situation where the swiper was within a view that occupied only part of the screen. By default, the swiper tried to take up the entire window width/height. I think the default behavior should be to occupy the containing component.
https://github.com/appintheair/react-native-looped-carousel/blob/master/index.js does a great job of this.
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the sizing behavior requested here with the referenced react-native-looped-carousel index.js, then inspect react-native-swiper's layout and measurement entry points. Done means the swiper defaults to the dimensions of its containing view rather than the full window, including when the container occupies only part of the screen.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100