v1.5.0 code-review request

Open

#243 opened on Sep 22, 2016 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted

Dominant language: JavaScript
Stars: 10.5k
Forks: 2.3k
PR merge metrics: No merged PRs in 30d

Description

ref: https://github.com/leecade/react-native-swiper#changelogs

There are two Major changes:

Adjust project structure, publish with src file, use watch-copy script and relative dependencies for improve develop workflow
```
"dependencies": {
    "react-native-swiper": "../"
},
```
ES6 syntex and standard[https://github.com/feross/standard] code style

Please help for more tests and code review, then release 1.5.0, thanks a lot.

@rajkissu
@sunnylqm
@tasiyo7333
@getnashty

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start with the referenced changelog and review the requested src-based project structure, watch-copy workflow, relative dependency setup, and ES6/standard code style. Identify the missing tests and review scope before making changes. Done means the changes are tested, reviewed, and suitable for releasing version 1.5.0.

Written by the indexing model from the issue text.

Assessment

Tech stack: javascript, react-native
Domain: mobile, release, tooling
Issue type: Refactor
Difficulty: 4/5
Estimated time: 3-5 days
Activity status: Stale
Clarity: Needs clarification
Newbie friendliness: 25/100

A short digest of beginner-friendly GitHub issues.