leecade / leecade/react-native-swiper

the loadMinimal logic may have a mistake

Open
#1,374 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
10.5k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

Which OS ?

windows

Version

Which versions are you using:

  • react-native-swiper v?1.6.0-rc.2
  • react-native v0.?.?0.73.0
Expected behaviour

​​​​The real last swiper should be keep
react-native-swiper1

Actual behaviour

The real penultimate swiper was kept.
swiper-screenshot

I read the source code and I think it's on line 836 should be 'loop && i === total ' instead ‘loop && i === total - 1’.

How to reproduce it>

<Swiper loadMinimal={true} loop={true}> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> <Image style={DetailStyle.image} resizeMode='contain' source={require('@/static/defaultAvator.jpeg')} /> </Swiper>

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the loadMinimal logic around line 836 and reproduce the issue with the provided Swiper example using loadMinimal and loop enabled. Verify which swiper is retained at the end of the list, and consider the issue resolved when the real last swiper is kept rather than the penultimate one.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.