leecade / leecade/react-native-swiper

Images are not loading properly if we change the orientation

Open
#1,293 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
10.5k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

Which OS ?
Version

Which versions are you using:

  • react-native-swiper v? 1.6.0
  • react-native v0.?.? 0.61.5
Expected behaviour

when changing the orientation of device, It must load the exact image i have reached after swiping

Actual behaviour

When changing the orientation, It is rendering two images (half portion of two images) have to manually swipe it.

How to reproduce it>

To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.

Steps to reproduce
  1. swipe imge in portrait mode
  2. change orientation
  3. Image get distorted in the screen.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue using the component and an example in the examples folder: swipe an image in portrait mode, rotate the device, and observe the distorted split between images. Done means changing orientation preserves the currently reached image without requiring another swipe.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.