leecade / leecade/react-native-swiper

When moving nextButton, an invisible nextButton remains in the default location

Open
#1,158 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
10.5k
Forks
2.3k
PR merge metrics
No merged PRs in 30d

Description

Which OS ? MacOS 10.14.6
Version

Which versions are you using:

  • react-native-swiper v? 1.5.14
  • react-native v0.?.? 0.59.8
Expected behaviour

When I use nextButton, I define it like this:

                            nextButton={
                                <View
                                    style={{
                                        position: 'relative',
                                        bottom: 322.5,
                                        right: 245,
                                    }}
                                >
                                    <Text>
                                        {button}
                                    <Text/>
                                </View>
                            }

I expect the relative position to move the nextButton from its default position.

Actual behaviour

The button is moved and works fine, but there is an invisible nextButton in the default position that when pressed will move to the next index in the swiper. It seems like a bug? How do I get rid of the invisible nextButton in the original position? The same happens with prevButton.

How to reproduce it

To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.

Steps to reproduce

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the report in an example under the examples folder using a positioned nextButton and prevButton. Check whether both the custom control and the default control respond to presses; done means the moved control still advances the swiper while no invisible control remains at the default location.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.