leecade / leecade/fe

An in-range update of handlebars is breaking the build 🚨

Open
#81 27 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

greenkeeper
Dominant language
JavaScript
Stars
15
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Version 4.0.9 of handlebars just got published.

Branch Build failing 🚨
Dependency handlebars
Current Version 4.0.8
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

handlebars is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Status Details
  • coverage/coveralls First build on greenkeeper/handlebars-4.0.9 at 12.808% Details
  • ci/circleci Your tests passed on CircleCI! Details
  • continuous-integration/appveyor/branch AppVeyor build succeeded Details
  • codecov/project 12.31% (-0.5%) compared to fe5bfde Details
  • codecov/patch Coverage not affected when comparing fe5bfde...cf307ea Details

Commits

The new version differs by 10 commits.

  • 5ec78a8 v4.0.9
  • 5333f31 Update release notes
  • 8a836e2 Handlebars.compile() does not modify "options" anymore
  • cc554a5 Fix build in windows
  • ed879a6 Ensure LF line-edings in handlebars-template fixtures (*.hbs)
  • 2e21e2b Run integration test with node handlebars -a ... on Windows
  • bdfdbea Ensure LF line-edings in lexer-files (*.l)
  • b50ef03 Force LF line-endings for spec/artifacts
  • 6e6269f Use istanbul/lib/cli.js instead of node_modules/.bin/istanbul
  • 7378f85 Publish valid semver task independently of the branch

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the dependency manifest and the greenkeeper/handlebars-4.0.9 branch, then compare the project's build output with the listed Handlebars 4.0.9 commits. Reproduce the failure with the project's build and test commands; done means the dependency update is integrated without breaking the build.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.