leecade / leecade/fe

An in-range update of deep-equal is breaking the build 🚨

Open
#110 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

greenkeeper
Dominant language
JavaScript
Stars
15
Forks
4
PR merge metrics
No merged PRs in 30d

Description

The dependency deep-equal was updated from 1.0.1 to 1.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

deep-equal is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/appveyor/branch: AppVeyor build failed (Details).
  • Travis CI - Branch: The build errored.
  • Build: Your Google Cloud Platform project is not set up correctly for this GitHub app. Please go through the setup flow again in the cloud console.

Commits

The new version differs by 22 commits.

  • 6099799 v1.1.0
  • 0c25e94 [Tests] make a tape helper, to easily compare loose/strict, and (a,b)/(b,a) arg order
  • 3fffed9 [Tests] clean up/flesh out test cases
  • cbbef21 [Tests] clean up redundant test
  • 410e2d6 [Refactor] objEquiv: bail early if typeofs are different
  • 0c5b21a [Fix] use is-date-object to properly detect cross-realm Dates
  • de4e75c [Fix] ensure Buffer + non-Buffer comparison order does not matter
  • 5b3bf31 [Refactor] move Date and RegExp tests into objEquiv
  • 558eecf [Tests] add array/object tests
  • ed266e8 [Tests] add tests for Object.create(null)
  • b8c179c [Fix] properly compare RegExp objects
  • 6a5efc1 [Refactor] there is no need to do further compareation when two types are not equal
  • 28fde4a [Fix] use object-is to support NaN and -0 properly
  • 7000403 [meta] fix license text so GitHub can detect it
  • bc37498 test: Fails simple array tests on IE < 9 #10

There are 22 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the direct deep-equal dependency declaration and reproduce the failing branch locally or through the reported AppVeyor and Travis CI builds. Compare the 1.0.1 and 1.1.0 behavior relevant to this project, then confirm the dependency choice or compatibility fix by getting the build checks to pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.