learningequality / learningequality/studio

Non-deterministic creation of perseus exercises

Open
#5,135 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P1 - important
Dominant language
Python
Stars
191
Forks
307
Avg merge
5d 6h
Merged PRs (30d)
10

Description

  • ricecooker version: 0.6.40
  • Python version: 3.5.3
  • Operating System: Linux
Description

Running Khan Academy zh-CN and it with nearly identical source trees resulted in all the exercises being marked as different and having to re-import them.

What I Did
  • Run KA chef, DEPLOY, PUBLISH
  • Import in Kolibri
  • Re-run KA chef, DEPLOY, PUBLISH
  • Update channel in Kolibri
Expected

Only one or two nodes to have changed (the topics nodes modified).

Actual

Every single exercise had changed and required re-importing.

Possible causes

I suspect two possible cause:

  1. this line could be the cause: https://github.com/learningequality/ricecooker/blob/master/ricecooker/classes/questions.py#L275 and since running on Python 3.5 the dict orders are not guaranteed to be consistent between different runs.

  2. The other possible cause is the .perseus file generation on Studio could be non-deterministic, see https://github.com/learningequality/studio/blob/develop/contentcuration/contentcuration/utils/publish.py#L342-L359 which uses create predictable zip code code slightly different from the predictable zip used in riececooker.

Real life consequences

Khan Academy channel users will need to redownload many files (small but still many) every time a new channel is published, even though exercises are substantially the same.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the repeated Khan Academy chef, DEPLOY, and PUBLISH workflow, then compare the generated exercise artifacts. Inspect ricecooker/classes/questions.py around line 275 and ricecooker/utils/zip.py, alongside Studio's contentcuration/utils/publish.py lines 342-359 and 445-450. Done means equivalent exercises produce deterministic outputs and avoid unnecessary re-imports.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.