learningequality / learningequality/studio

Migrate Studio dropshadows to KDS

Open
#4,820 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

DEV: frontend TODO: needs decisions
Dominant language
Python
Stars
191
Forks
307
Avg merge
5d 6h
Merged PRs (30d)
10

Description

This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Summary

As part of migrating Studio to KDS, we will need to move away from Vuetify's elevation system to using KDS dropshadows. We will also need to remove custom box-shadows.

Guidance

References

Relevant places discovered so far:

Needs decision

  • Will we want to update styles/vuetify.scss or just remove elevations from there completely?
  • How do we best scope these updates: sub-tasks, all at once?
  • At what point this would be suitable to do?
    • @MisRob: Since Studio still uses many Vuetify components that are presumably consistent with the elevation styles, I wonder if this would be one of the last tasks to do in the migration process?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the repository search for box-shadow, then inspect contentcuration/contentcuration/frontend/shared/styles/vuetify.scss and the referenced ImagesMenu.vue. Read the KDS dropshadow and Studio design guidance, then resolve the open scoping decisions before changing the relevant elevation styles. Done means Studio no longer relies on Vuetify elevations or custom box shadows where the migration requires KDS dropshadows.

Written by the indexing model from the issue text.

Assessment

Domain
design, frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.