learningequality / learningequality/studio

Import channel search: language filtering requires re-thinking

Open
#4,389 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P1 - important TODO: needs decisions
Dominant language
Python
Stars
191
Forks
307
Avg merge
5d 6h
Merged PRs (30d)
10

Description

Observed behavior

Filtering by language in import channel search isn't working as expected.

Expected behavior

Filtering by language should work as expected.

User-facing consequences

Wrong results when filtered by language.

Additional information

Presently, filtering by language in import from channel search uses contentcuration's model's language value. But we set language during publish on exported database. So, filtering by language is giving wrong results.

We need to handle this for both channel types -- public, and private.

Steps to reproduce the issue
  1. Create a channel with a specific language.
  2. Add a resource without setting its language explicitly.
  3. Publish that channel.
  4. Create another channel.
  5. Go to import channel search.
  6. Select My channels from Channels dropdown.
  7. Now, enter a search term that displays that resource.
  8. In the results page, in Language dropdown, select the published channel language.
  9. You will see zero results.
Usage Details
  • OS: Ubuntu 22.04
  • Browser: Chrome
  • URL: Latest unstable

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the import channel search language filter and trace how language is read for published resources. Compare the model language with the language set during publishing for both public and private channels, then reproduce the listed steps and confirm that the expected channel language returns the resource.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend, search
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.