learningequality / learningequality/studio

Cleanup broken and incorrect configuration in Makefile

Open
#3,711 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

DEV: dev-ops DEV: sysops TAG: tech update / debt
Dominant language
Python
Stars
191
Forks
307
Avg merge
5d 6h
Merged PRs (30d)
10

Description

Desired behavior

  • Update the Makefile so that:
    • altprodserver is renamed to appserver
    • the gunicorn settings match that of the currently deployed configuration, shown in Current Behavior
    • compilemessages is no longer a dependency and its recipe is removed
  • Update the app image's command to default to appserver

Current behavior

The current gunicorn settings in production

      - args:
        - contentcuration.wsgi:application
        - --timeout=4000
        - --workers=2
        - --bind=0.0.0.0:8081
        - --pid=/tmp/contentcuration.pid
        command:
        - gunicorn

Value add

Clear up discrepancies between the codebase and what's implemented in production

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Makefile and locate the app image command configuration. Compare its gunicorn settings with the production configuration shown in the issue, then verify that the target rename, dependency removal, recipe removal, and default command changes are all represented. Done means the codebase configuration matches the stated production behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, devops
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.