learningequality / learningequality/studio
Replace unnecessary dialogs by regular pages
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 191
- Forks
- 307
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 10
Description
In the past, we had lots of nested child routes, and we've been extensively using dialogs as fullscreen modals (for example ChannelModal and ChannelSetModal). Routes were flattened already though we had no time to convert those dialogs to regular pages. One of the reasons was that there's lots of layout logic implemented in FullscreenModal, and such refactor would be much larger than we could afford. After vue migration is done, let's check our routes and convert all unnecessary dialogs to regular pages together with using layouts like ImmersiveModalLayout.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
After the Vue migration, review the routes and inspect ChannelModal, ChannelSetModal, FullscreenModal, and ImmersiveModalLayout. Identify dialogs that are being used as fullscreen pages and compare their layout logic with the available page layout. Done means unnecessary dialogs have been converted to regular pages without losing required layout behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100