learningequality / learningequality/morango
Drop foreign key constraint to Store table
Open
@bjester is already working on this.
Since Jun 7, 2022.
DEV: backend
- Dominant language
- Python
- Stars
- 15
- Forks
- 23
- PR merge metrics
- No merged PRs in 30d
Description
Background
While implementing postgres table partitioning for the morango_store table, an overlooked restriction regarding primary keys on the store table popped up. Except under specific partition strategy circumstances, primary keys cannot be enforced on partitioned tables. For the morango_store table, this would be okay, except for any foreign key references to the PK field.
Since we expect the store PK field values to be unique regardless, we'd like to drop the sole FK constraint to the field.
Deliverables
- Update the
store_modelfield onRecordMaxCounterto drop the FK constraint- The uniqueness constraint should remain and a rebuild of it should be avoided
- Bonus: it would be great to also add an explicit
on_delete=models.CASCADEto all FK fields, since the existing implicit behavior is deprecated in Django 2+
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.