leanprover / leanprover/vscode-lean4
Intercept `applyEdit` and reveal the change position
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 313
- Forks
- 104
- Avg merge
- 1h 56m
- Merged PRs (30d)
- 1
Description
When the infoview makes insertText calls, we also reveal the changed text in an editor. On the other hand when the server sends an applyEdit LSP request, we don't, but we perhaps should. It would likely help with https://github.com/leanprover/vscode-lean4/issues/225#issuecomment-1199217160. CC @javra
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read vscode-lean4/src/infoview.ts around the insertText call at line 208, then trace where the extension handles server-sent LSP workspace/applyEdit requests. Compare how the existing path reveals changed text and make applyEdit reveal the corresponding change position, including the behavior described in issue 225.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript, vscode
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 43/100