leanprover / leanprover/vscode-lean4

Tachyons?

Open
#183 18 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
313
Forks
104
Avg merge
1h 56m
Merged PRs (30d)
1

Description

I missed this before, but so far we have mostly been using Tachyons rather than bespoke CSS classes for styling of this kind (with the exception of this exact file, of course). So instead of popup-menu-text one would write tc pa2 v-top dib as the className (pa1 or pa2, Tachyons intentionally doesn't provide specific pixel offsets for padding so as to keep a consistent, fixed scale). All the other classes either use var or need specific offsets to match a font, so it only applies to popup-menu-text. I will leave to you whether you want to change this, it's not the end of the world if we use classes.

Interesting. Does VS Code itself actually use responsive UI design? Meaning spacing/fontsize/padding change with screen size?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the popup-menu-text class and its className usage in the extension UI. Compare that styling with the Tachyons classes discussed in the issue, then confirm whether the intended outcome is to replace this exact class or leave it unchanged. Done means the styling decision is implemented consistently and the relevant UI still matches its existing appearance.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, typescript
Domain
design, frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.