leanprover / leanprover/lean4

matches using `match_pattern` do not generate the right equation lemmas

Open
#9,712 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

When using a match_pattern in a match clause, the equation lemma generated unfolds the match pattern.

Context

#mathlib4 > refactoring WithTop/WithBot as inductive types @ 💬

Steps to Reproduce
  1. Run
-- one field structure
structure MyOptionStruct where
  toOption : Option Nat

@[match_pattern]
def MyOptionStruct.some : Nat → MyOptionStruct := fun n => ⟨.some n⟩

@[match_pattern]
def MyOptionStruct.null : MyOptionStruct := ⟨Option.none⟩

def foo : MyOptionStruct → Nat
  | .some n => n
  | .null => 0

theorem wat : foo (.some 1) = 2 := by
  rw [foo] -- fails

#check foo.eq_1

Expected behavior: The rewrite succeeds.

Actual behavior: The rewrite fails, because the equation lemma is about MyOptionStruct.mk.

Versions

[Output of #version or #eval Lean.versionString]
[OS version, if not using live.lean-lang.org.]

Additional Information

[Additional information, configuration or data that might be necessary to reproduce the issue]

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the self-contained reproducer in the issue and inspect how equation lemmas are generated for match clauses using match_pattern. Run the wat theorem and check foo.eq_1; done means rw [foo] succeeds without the equation lemma being reduced to MyOptionStruct.mk.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.