leanprover / leanprover/lean4

Missing borrow annotations in `Std.Internal.UV.System`

Open
#9,657 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-high
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

In https://github.com/leanprover/lean4/blob/30ceb3260d7d7536092fedff969b4b2e8de7f942/src/Std/Internal/UV/System.lean, there are several functions that accept a String argument which is received as a b_obj_arg in the runtime, but which are missing the borrow annotation.

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/Std/Internal/UV/System.lean and inspect the functions accepting String arguments that are received as b_obj_arg in the runtime. Confirm the missing borrow annotations and validate the change with the issue's minimal, self-contained test case against the latest Lean nightly.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.