leanprover / leanprover/lean4

`omit` not working for Prop-valued instances

Open
#9,597 3 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

Currently, lemmas only use variables in the context that are referred to in the statement, while definitions use variables that are refereed to in the statement and in the body. I would expect that Prop-valued instances behave like lemmas, and data-carrying instances behave like definitions, but this is not the case: omit does not work for Prop-valued instances.

Context

This issue is a minimization of an issue showing up in mathlib, see discussion at #mathlib4 > Is `omit` broken? @ 💬

Steps to Reproduce

Run the following code:

class A (α : Type) : Prop where
class B (α : Type) : Prop where
class C (α : Type) : Prop where

instance BtoC (α : Type) [B α] : C α := {}
instance AtoC (α : Type) [A α] : C α := {}

variable (α : Type) [h : A α]

omit h in
instance myinst [B α] : C α := by
  infer_instance

#check myinst -- myinst (α : Type) [h : A α] [B α] : C α

Expected behavior: Since myinst is a Prop-valued instance, I expect the line omit h to work, and the infer_instance line to use BtoC, as there should be no assumption [A α] in the context.

Actual behavior: h is not omitted, so [A α] is available in the proof of myinst, and is used in the infer_instance line. In the end, myinst requires both [A α] and [B α].

Versions

Lean 4.23.0-nightly-2025-07-28
Target: x86_64-unknown-linux-gnu

Additional Information
Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the minimal reproduction in the issue against the stated Lean nightly version, then trace the implementation of omit for Prop-valued instances. Done means h is absent from myinst and the proof uses BtoC, leaving myinst dependent only on [B α].

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.