leanprover / leanprover/lean4

Better error message for indentation problems?

Open
#9,573 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Consider:

example : ∀ (p : Prop), p → p := by
   intros p h
  exact h

The error message on the third line is unexpected identifier; expected command. Is it technically conceivable that it could be something like unexpected unindent instead?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the Lean snippet shown and compare the diagnostic produced at the misindented exact h line. Trace the parser or indentation-error handling from that failure; done means the diagnostic clearly identifies the unexpected unindent, with tests covering the example.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.