leanprover / leanprover/lean4

Illegal theorem names give a confusing error message

Open
#9,450 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

When accidentally creating a theorem name that starts with a digit, the error messages can be confusing; especially if the name contains an e.

Context

[Broader context that the issue occurred in. If there was any prior discussion on the Lean Zulip, link it here as well.]

Steps to Reproduce
  1. Run
theorem 1easy : True := sorry
--            ^ missing exponent digits in scientific literal
theorem 1hard : True := sorry
--     ^ unexpected token; expected identifier

Expected behavior: Both errors appear at the 1 position

Actual behavior: The errors in the comments appear at the marked positions

Versions

[Output of #version or #eval Lean.versionString]
[OS version, if not using live.lean-lang.org.]

Additional Information

[Additional information, configuration or data that might be necessary to reproduce the issue]

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Run the minimal theorem examples against the latest Lean nightly in live.lean-lang.org and confirm where each diagnostic is reported. Trace the handling of theorem names beginning with digits, then verify that both errors point to the initial 1 position without introducing dependencies on Mathlib or Batteries.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.