leanprover / leanprover/lean4

"Rename symbol" does not work with `generalize`

Open
#9,409 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The "Rename symbol" operation in vscode does not see through the generalize tactic

Context

This came up while investigating things similar to #metaprogramming / tactics > Persisting hypotheses across tactics @ 💬

Steps to Reproduce
  1. Run the following code
    example (x : Nat) (hx : (x + x) + (x + x) = 2) : x + x = 1 := by
      generalize h : x + x = y at *
      let p := hx
      sorry
    
  2. Put your cursor on the first hx
  3. Run "Rename symbol" in vscode, and type hx2

Expected behavior: Both hxs change to hx2, and the proof keeps working.

Actual behavior: Only the first one changes, and the proof breaks.

Versions

Lean 4.23.0-nightly-2025-07-16
Target: x86_64-unknown-linux-gnu

Additional Information

Modifying the tactic to record ofFVarAliasInfos fixes this, but there is some disagreement over whether this is a correct use of this feature.

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the minimal Lean example in the issue and reproduce the failure through VSCode's "Rename symbol" operation. Trace how the generalize tactic handles the aliased hypothesis and inspect the mentioned ofFVarAliasInfos behavior. Done means renaming either hx updates both occurrences and the proof continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
vscode
Domain
compilers, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.