leanprover / leanprover/lean4

`simp` abstracts too many meta-variables

Open
#9,286 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

simp abstracts meta-variables in proof terms, even if they existed before the elaborating the term. This results in it falsely generalizing

Context

I'm writing my own simp and I noticed a kernel error after switching to abstractMVars (what simp uses) which lead me to finding out about this issue.

Steps to Reproduce
inductive SomeThing.{u} : Prop where
  | mk (_ : PUnit.{u})

set_option pp.universes true in
def testMe (a : PUnit) : PLift SomeThing := by
  /-
  a : PUnit.{?u.10}
  ⊢ PLift.{0} SomeThing.{?u.14}
  -/
  constructor
  simp only [SomeThing.mk a] -- SomeThing.mk.{?u.10} a

Expected behavior: simp should fail since the universe meta-variables are different and simp shouldn't assign them.

Actual behavior: simp abstracts the universe meta-variable ?u.10 even though it relies on it specifically being ?u.10, causing a kernel application mismatch. A similar issue occur for regular meta-variables.

Versions

Lean 4.23.0-nightly-2025-07-09

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the minimal Lean example and inspect the interaction between simp and abstractMVars, including the analogous regular meta-variable case. The fix is done when simp no longer abstracts pre-existing meta-variables it relies on, and the example fails as expected without a kernel application mismatch.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.