leanprover / leanprover/lean4

`casesOn` allows accessing private structure fields

Open
#8,665 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The automatically generated casesOn implementation for structures allows access to private fields. This works even when the constructor is private, which prevents pattern matching.

Steps to Reproduce

File A:

structure Test where
  private mk ::
  private field : Nat

File B that imports File A:

def Test.field' (self : Test) : Nat :=
  self.casesOn id

Expected behavior: field cannot be accessed outside of File A since it is private.

Actual behavior: File B can access field.

Versions

Lean 4.21.0-nightly-2025-06-06

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the reproduced two-file example in the issue and investigate how Lean generates casesOn for structures, especially when the constructor and fields are private. Verify that File B cannot access the private field while pattern matching remains unavailable. The issue does not identify a source file or test, so locate the relevant implementation and add a regression test.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
47/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.