leanprover / leanprover/lean4

open subgoal elsewhere changes refine behavior

Open
#8,643 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

Consider the following to examples:

example : True ∧ True := by
  constructor
  · sorry
  · -- fails
    refine (Decidable.byContradiction fun h => ?_ :) 
    sorry
    sorry
    
example : True ∧ True := by
  constructor
  · skip
  · -- succeeds
    refine (Decidable.byContradiction fun h => ?_ :) 
    sorry
    sorry

It is surprising that the existence of an open subgoal elsewhere changes the behavior of refine.

Context

This lead to undesired behavior in the by_contra tactic leanprover-community/batteries#1196 (which will likely be patched independent of this issue.

Versions

4.21.0-rc3

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two minimal examples on the Lean nightly release, comparing the refine behavior when the earlier subgoal uses sorry versus skip. The issue names no source file or test path; done means the behavior no longer depends on an unrelated open subgoal and a regression test covers both examples.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.