`IO.Process.spawn` on windows insert additional quotes, leading to errors for certain kinds of commands
Nobody has claimed this yet.
- Dominant language
- Lean
- Stars
- 9.2k
- Forks
- 990
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 175
Description
Prerequisites
Please put an X between the brackets as you perform the following steps:
- Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues - Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries. - Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)
Description
IO.Process.spawn inserts additional unnecessary quotes, leading to problems trying to execute e.g. cmd.exe /c echo hi because the current quoting turns it into "cmd.exe" "/c" "echo" "hi", producing an error unknown command ""echo"". Avoiding unnecessary quoting should solve this issue.
Context
This came up while trying to write a test for #8534. The "solution" I used highlights another problem which is that the command string is not correctly quoted.
Steps to Reproduce
#eval return (← IO.Process.output { cmd := "cmd.exe", args := #["/c", "echo", "hi"] }).stderr
Expected behavior: The process should run successfully and produce no stderr. The output should be: "hi\r\n".
Actual behavior: The process produces an error message along the lines of unknown command ""echo"".
Versions
Lean 4.21.0-nightly-2025-05-30
Impact
Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the IO.Process.spawn entry point and reproduce the Windows case with IO.Process.output using cmd.exe and args #["/c", "echo", "hi"]. Compare the actual stderr with the expected "hi\r\n" and verify that the command runs without the unknown-command error. The issue mentions a test for #8534, but gives no test file path.
Written by the indexing model from the issue text.
Assessment
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100