leanprover / leanprover/lean4

`apply` duplicates goals

Open
#8,436 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The apply tactic sometimes duplicates the same MVarId in the list of goals

Context

Came up when trying to use split on a target containing metavariables.

Steps to Reproduce

Run

theorem apply_duplicate_goal : ∃ a : Int, a = 1 := by
  refine ⟨?x, ?y⟩
  rotate_left
  apply (eq_comm (b:=?x)).mp
  -- three goals
  sorry
  -- two goals
  sorry
  -- zero goals

(The (b:=?x) is actually optional.)

Expected behavior: There should be two goals after apply

Actual behavior: The goal state after apply is

case y
⊢ 1 = ?x
case x
⊢ Int
case x
⊢ Int
Versions

Lean 4.21.0, commit ebf455a13780ea508abee8016b8bb6c5549bf9d7

Additional Information

This is likely the same issue as https://github.com/leanprover/lean4/issues/6407.

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the minimal apply_duplicate_goal theorem and reproduce the goal state using the listed Lean 4.21.0 version. Trace the apply tactic from this example and verify that the same MVarId is not listed twice, leaving the expected two goals.

Written by the indexing model from the issue text.

Assessment

Domain
compilers, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.