leanprover / leanprover/lean4

Closing bracket in auto-completion retains completion popup

Open
#8,430 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Description

Downstream of Mathlib, typing b) creates an auto-completion pop-up with completion items that contain the character ). This can interfere with input, e.g. when attempting to enter a new line after a bracket.

Context

Discussion: #lean4 > VSCode completion on brackets @ 💬

Steps to Reproduce

Type the following:

import Mathlib

#check b)

Expected behavior: Completion menu disappears so that it doesn't interfere with input.

Actual behavior: Completion menu remains when typing the closing bracket.

Versions

v4.20.0-rc5
36d4490354b047cee71a95007105de44e87b7255 of Mathlib

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the Lean snippet from the report and inspect the VSCode completion handling for closing brackets. The payload names no source files or tests, so first locate the completion popup logic and any related editor tests. Done means typing b) dismisses the completion menu without interfering with subsequent input.

Written by the indexing model from the issue text.

Assessment

Tech stack
vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.