leanprover / leanprover/lean4

Calling initialize_runtime_module twice in the same process leads to data race conditions

Open
#7,753 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

If from a C program you call

int main() {
initialize_runtime_module();
finalize_runtime_module();
initialize_runtime_module();
finalize_runtime_module();
}

then this both leaks memory and results in a data race, as the uv event loop started by the initializer is not stopped, and then is subsequently started for a second time in a new thread.

https://github.com/leanprover/lean4/pull/7752 is a rough attempt at fixing this.

Context

[Broader context that the issue occurred in. If there was any prior discussion on the Lean Zulip, link it here as well.]

Steps to Reproduce
  1. Run the above C code under thread sanitizer or similar

Expected behavior: No errors

Actual behavior: Data race on event_loop->loop

Versions

Fails in v4.17.0.

Additional Information
Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the initialize_runtime_module and finalize_runtime_module entry points and reproduce the C example under ThreadSanitizer. Inspect the uv event loop state involved in the reported event_loop->loop race, and review pull request 7752; done means repeated initialization and finalization produce no leak or race.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.