leanprover / leanprover/lean4

forall_congr should be generalized from Prop to Sort

Open
#7,507 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-medium
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

forall_congr currently has type

theorem forall_congr {α : Sort u} {p q : α → Prop} (h : ∀ a, p a = q a) : (∀ a, p a) = (∀ a, q a)

but could (should?) have type

theorem forall_congr {α : Sort u} {p q : α → Sort v} (h : ∀ a, p a = q a) : (∀ a, p a) = (∀ a, q a)

in order to accept more proofs using conv mode, which uses this theorem.

Steps to Reproduce
axiom ID : Type → Type
axiom ID.eq {α} : ID α = α
example : ((x:Type) → ID x) = ((x : Type) → x) := by
  conv => lhs; ext; apply ID.eq

live.lean

Expected behavior: No error

Actual behavior: The following error, reported while hovering over example:

application type mismatch
  @forall_congr Type fun x => ID x
argument has type
  Type → Type
but function has type
  ∀ {p q : Type → Prop}, (∀ (a : Type), p a = q a) → (∀ (a : Type), p a) = ∀ (a : Type), q a

By comparison, the following works:

-- theorem forall_congr {α : Sort u} {p q : α → Prop} (h : ∀ a, p a = q a) : (∀ a, p a) = (∀ a, q a) :=
theorem Better.forall_congr {α : Sort u} {p q : α → Sort v} (h : ∀ a, p a = q a) : (∀ a, p a) = (∀ a, q a) :=
  (funext h : p = q) ▸ rfl

example : ((x:Type) → ID x) = ((x : Type) → x) := by
  apply Better.forall_congr
  apply ID.eq
Versions

"4.19.0-nightly-2025-03-15"

Additional Information
Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the definition of forall_congr and the implementation or tests for conv mode. Generalize the theorem from predicates returning Prop to families returning Sort, then run the provided ID reproduction and confirm that the conv example reports no error.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.