leanprover / leanprover/lean4

bv_decide? should write to a temporary file, not the source directory

Open
#7,442 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

There is no guarantee that the source directory is writable (or in the case of a temporary buffer, that the file even exists), and so this can cause bv_decide? to fail.

Writing to a temporary file or directory should avoid this issue, and presumably can also help avoid race conditions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and tests for bv_decide?, then inspect how it chooses the source path for generated output. Done means it works when the source directory is not writable or the temporary buffer has no file, without introducing race conditions.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.