leanprover / leanprover/lean4

Keep goal view active on unparsed input

Open
#7,135 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-high
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

example : True := by
  skip
  ski
example : True := by
  skip
  exact \<

ski and \< are parse errors and thus not part of the info tree ranges. We should make sure they are considered trailing input to the skip node and thus share its goal view.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the two Lean examples in the issue and inspect how parse errors are excluded from info tree ranges and how trailing input is associated with the skip node. Verify the goal view for ski and \< after the change, including that both inputs share the skip goal view.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.