leanprover / leanprover/lean4

trySuggestions (exact? etc.) can produce wrongly indented source

Open
#6,626 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug P-low
Dominant language
Lean
Stars
9.2k
Forks
990
Avg merge
1d 17h
Merged PRs (30d)
175

Description

Prerequisites

Please put an X between the brackets as you perform the following steps:

Description

The result of clicking "Try this" after an exact? gives "type mismatch" and "unexpected identifier; expected command" errors.

theorem AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA :
    True → True → 1 = 2 := by 
  sorry

theorem test : 1 = 2 := by exact?

live.lean-lang.org version

Context

A student encountered this when using exact? on mathlib.

Steps to Reproduce
  1. Code as above
  2. Click the try this suggestion from exact?

Expected behavior: The result of exact? should close the goal.

Actual behavior: The result of exact? gives two errors, both of which are unhelpful to beginners.

Versions

Using live.lean-lang.org:
Lean 4.16.0-nightly-2025-01-10
Target: x86_64-unknown-linux-gnu

Impact

Add 👍 to issues you consider important. If others are impacted by this issue, please ask them to add 👍 to it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the minimal reproduction in the issue and reproduce it on the Lean nightly version; the reported failure occurs after clicking “Try this” for exact?. Compare the generated suggestion with the expected goal-closing behavior, then verify that using it no longer produces the reported type-mismatch and unexpected-identifier errors.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.